Ensure we always pull fresh data when making API requests in the admin #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-alvi
previously approved these changes
May 12, 2025
Contributor
faisal-alvi
left a comment
faisal-alvi
left a comment
There was a problem hiding this comment.
Thank you! Tested it and it works well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We have caching around the API request we make to store that for 24 hours (or up to 24 hours to be accurate). We already have a mechanism in place to bypass that cache and this PR takes advantage of that to ensure we always get the most up-to-date data when an API request is made in the admin (in this case, the block editor).
How to test the Change
Ensure the block renders properly in the admin
Changelog Entry
Credits
Props @dkotter
Checklist: