InteractionsController: Remove URL escaping of redirect_url

[akirk]

If the redirect URL contains an ampersand, this gets wrongly escaped in the redirect.

Proposed changes:

• The esc_url is not needed.

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

Use the Friends plugin with akirk/friends#544 and notice that the redirect URL contains a #038 instead of an ampersand.

Without this fix, the tests fail like this:

1) Activitypub\Tests\Rest\Test_Interaction_Controller::test_get_item_custom_follow_url
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'https://custom-follow-or-reply-url.com/?a=b&c=d'
+'https://custom-follow-or-reply-url.com/?a=b&c=d'

tests/includes/rest/class-test-interaction-controller.php:114

2) Activitypub\Tests\Rest\Test_Interaction_Controller::test_get_item_custom_reply_url
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'https://custom-follow-or-reply-url.com/?a=b&c=d'
+'https://custom-follow-or-reply-url.com/?a=b&c=d'

tests/includes/rest/class-test-interaction-controller.php:146

Changelog entry

• Automatically create a changelog entry from the details below.

InteractionsController: Remove URL escaping of redirect_url

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message

Allow interaction redirect URLs that contain an ampersand.