Skip to content

Conversation

@ruslanfialkovskii
Copy link
Contributor

  • Enhanced flatten_table_to_string to filter out empty error messages
  • Added logic to distinguish actual errors from empty stderr output
  • Prevents false error reporting when VectorCode operations succeed but have no stderr
  • Provides meaningful fallback error message for truly empty error conditions
  • Fixes issue where successful operations with empty stderr were reported as { "" } errors

Resolves the confusing empty error message issue in CodeCompanion integration.

@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.72%. Comparing base (af52fed) to head (c131596).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          25       25           
  Lines        1838     1838           
=======================================
  Hits         1833     1833           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@Davidyz Davidyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please review my comments (mostly about reusing code where possible) and lmk what you think about them. Happy to merge once we're in agreement about those.

- Enhanced flatten_table_to_string to filter out empty error messages
- Added logic to distinguish actual errors from empty stderr output
- Prevents false error reporting when VectorCode operations succeed but have no stderr
- Provides meaningful fallback error message for truly empty error conditions
- Fixes issue where successful operations with empty stderr were reported as { "" } errors

Resolves the confusing empty error message issue in CodeCompanion integration.
@Davidyz Davidyz force-pushed the fix/codecompanion-error-handling branch from 7f8cb1d to 744182d Compare September 20, 2025 02:34
@Davidyz Davidyz self-requested a review September 20, 2025 03:23
@Davidyz Davidyz added bug Something isn't working fix labels Sep 20, 2025
@Davidyz Davidyz merged commit 5ac5502 into Davidyz:main Sep 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants