fixed all the unittests from #5327

[wenyikuang]

• Fix [CI] Mac incremental has failing tests on all branches #5327

The only one test left from 5327 is BCLFixture.RemoteBCL_BCLSearchResult and fixed by set the

m_provenanceRequired to false explictly. The m_provenanceRequired to be true and then BCLSearchResult::provenanceRequired returns true even though should not be.

The old logic make the unittest broken b/c:

1. initialize the m_provenanceRequired == true
2. Didn't run the logic in constructor here and still be true.
3. Find the comflict in unittest here

The new logic solved the issue by:

Forcely set the value of m_provenanceRequired as false from start in BCL.hpp.

ctest -R "BCLFixture.RemoteBCL_BCLSearchResult" -V
UpdateCTestConfiguration  from :/Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/DartConfiguration.tcl
Parse Config file:/Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/DartConfiguration.tcl
UpdateCTestConfiguration  from :/Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/DartConfiguration.tcl
Parse Config file:/Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/DartConfiguration.tcl
Test project /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 665
    Start 665: BCLFixture.RemoteBCL_BCLSearchResult

665: Test command: /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/Products/openstudio_utilities_tests "--gtest_filter=BCLFixture.RemoteBCL_BCLSearchResult" "--gtest_also_run_disabled_tests"
665: Working Directory: /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/src/utilities
665: Test timeout computed to be: 660
665: Running main() from gmock_main.cc
665: Note: Google Test filter = BCLFixture.RemoteBCL_BCLSearchResult
665: [==========] Running 1 test from 1 test suite.
665: [----------] Global test environment set-up.
665: [----------] 1 test from BCLFixture
665: [ RUN      ] BCLFixture.RemoteBCL_BCLSearchResult
665: Calling the metaSearch[       OK ] BCLFixture.RemoteBCL_BCLSearchResult (3091 ms)
665: [----------] 1 test from BCLFixture (3091 ms total)
665: 
665: [----------] Global test environment tear-down
665: [==========] 1 test from 1 test suite ran. (3091 ms total)
665: [  PASSED  ] 1 test.
1/1 Test #665: BCLFixture.RemoteBCL_BCLSearchResult ...   Passed    3.15 sec

The following tests passed:
	BCLFixture.RemoteBCL_BCLSearchResult

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   3.40 sec

Pull request overview

• Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

To fix the only one unittest failed from #5327 .

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[wenyikuang]

Well it fixed
BCLFixture.RemoteBCL_BCLSearchResult

but

	2313 - ModelFixture.ScheduleFile (Failed)

	2472 - ModelFixture.Space_Convexity (Failed)

[ci-commercialbuildings]

CI Results for b2b96d9:

• Ubuntu 24.04:

  • OpenStudio-3.9.1-alpha+b2b96d9901-Ubuntu-24.04-x86_64.deb
  • OpenStudio-3.9.1-alpha+b2b96d9901-Ubuntu-24.04-x86_64.tar.gz

• Ubuntu 22.04:

  • OpenStudio-3.9.1-alpha+b2b96d9901-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.9.1-alpha+b2b96d9901-Ubuntu-22.04-x86_64.tar.gz
  • perf_test/results.html

• Darwin:

  • OpenStudio-3.9.1-alpha+b2b96d9901-Darwin-x86_64.dmg
  • OpenStudio-3.9.1-alpha+b2b96d9901-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.9.1-alpha+b2b96d9901-Windows.exe
  • OpenStudio-3.9.1-alpha+b2b96d9901-Windows.tar.gz

• Code Coverage:

[wenyikuang]

Well, all unittests fixed after you pushed the change into the PR(Thank you!) and I think we are good to merge when you think it's propriate. @jmarrec