Skip to content

Fix #5355 - E+ 25.1.0: Wrap OutputControl:ResilienceSummaries #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmarrec merged 5 commits into from
Mar 13, 2025
Merged

Fix #5355 - E+ 25.1.0: Wrap OutputControl:ResilienceSummaries #5365

jmarrec merged 5 commits into from
Mar 13, 2025

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Mar 12, 2025 •
edited
Loading

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Mar 12, 2025
@jmarrec jmarrec self-assigned this Mar 12, 2025
@jmarrec jmarrec force-pushed the 5355-OutputControlResilienceSummaries branch from 52e206f to 51228c2 Compare March 12, 2025 09:20
@jmarrec jmarrec mentioned this pull request Mar 12, 2025
Merged
11 tasks
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Mar 12, 2025 •
edited
Loading

CI Results for 51228c2:

joseph-robertson
joseph-robertson approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty complete to me. Just a (unrelated) question.

src/sdd/ForwardTranslator.cpp
m_ignoreTypes.push_back(model::ModelObjectList::iddObjectType());
m_ignoreTypes.push_back(model::Node::iddObjectType());
m_ignoreTypes.push_back(model::OutputControlReportingTolerances::iddObjectType());
m_ignoreTypes.push_back(model::OutputControlResilienceSummaries::iddObjectType());
Copy link
Collaborator

@joseph-robertson joseph-robertson Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but... should other OutputControl objects be in this list?

Copy link
Collaborator Author

@jmarrec jmarrec Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. OutputSchedules too for eg.

I don't know who uses SDD these days to be honest, and I'll happily just ignore this until someone complains about the warnings

@jmarrec jmarrec merged commit c25aa50 into develop Mar 13, 2025
4 of 6 checks passed
@jmarrec jmarrec deleted the 5355-OutputControlResilienceSummaries branch March 13, 2025 11:35
jmarrec added a commit that referenced this pull request Mar 20, 2025
@jmarrec
Hotfix C# bindings for #5365
d821507
@jmarrec jmarrec mentioned this pull request Mar 20, 2025
Merged
19 tasks
jmarrec added a commit that referenced this pull request Apr 1, 2025
@jmarrec
Hotfix C# bindings for #5365
180df4e
@jmarrec jmarrec mentioned this pull request Jul 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseph-robertson joseph-robertson joseph-robertson approved these changes

Assignees

@jmarrec jmarrec

Labels

component - Model IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E+ 25.1.0: Wrap OutputControl:ResilienceSummaries

4 participants

@jmarrec @ci-commercialbuildings @joseph-robertson