Skip to content

#5395 - Space infiltration helpers #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kbenne merged 2 commits into from
Apr 30, 2025
Merged

#5395 - Space infiltration helpers #5396

kbenne merged 2 commits into from
Apr 30, 2025

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Apr 9, 2025

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added Enhancement Request component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Apr 9, 2025
@jmarrec jmarrec self-assigned this Apr 9, 2025
@jmarrec jmarrec force-pushed the 5395-SpaceSetInfiltrationHelpers branch from 8ccec70 to 4445c9d Compare April 25, 2025 07:09
@jmarrec jmarrec force-pushed the 5395-SpaceSetInfiltrationHelpers branch from 4445c9d to 4d5ed77 Compare April 25, 2025 08:07
@jmarrec jmarrec marked this pull request as ready for review April 25, 2025 09:58
jmarrec
jmarrec commented Apr 25, 2025
View reviewed changes
src/model/Space.cpp
#include <algorithm>
#include <cmath>
#include <iterator>
#include <ranges>
Copy link
Collaborator Author

@jmarrec jmarrec Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wary of bringing ranges into OpenStudio due to MSVC lagging behind in supporting them, but I guess it works now! yay!

src/model/Space.cpp
Comment on lines +2240 to +2243
auto& spi = spis[0];
for (auto& spi : spis | std::views::drop(1)) {
spi.remove();
}
Copy link
Collaborator Author

@jmarrec jmarrec Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First std::views spotted in OS SDK! yay!

Copy link
Contributor

@kbenne kbenne Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh. I can't keep up.

Copy link
Contributor

@kbenne kbenne Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I had the opportunity to learn something today. Thanks @jmarrec :)

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Apr 25, 2025 •
edited
Loading

CI Results for 51681d2:

@DavidGoldwasser DavidGoldwasser added this to the OpenStudio SDK 3.10.0 milestone Apr 29, 2025
kbenne
kbenne approved these changes Apr 30, 2025
View reviewed changes
src/model/Space.cpp
Comment on lines +2240 to +2243
auto& spi = spis[0];
for (auto& spi : spis | std::views::drop(1)) {
spi.remove();
}
Copy link
Contributor

@kbenne kbenne Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh. I can't keep up.

src/model/Space.cpp
Comment on lines +2240 to +2243
auto& spi = spis[0];
for (auto& spi : spis | std::views::drop(1)) {
spi.remove();
}
Copy link
Contributor

@kbenne kbenne Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I had the opportunity to learn something today. Thanks @jmarrec :)

@kbenne kbenne merged commit db8f950 into develop Apr 30, 2025
3 of 6 checks passed
@kbenne kbenne deleted the 5395-SpaceSetInfiltrationHelpers branch April 30, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbenne kbenne kbenne approved these changes

@joseph-robertson joseph-robertson Awaiting requested review from joseph-robertson

Assignees

@jmarrec jmarrec

Labels

component - Model Enhancement Request Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Milestone

OpenStudio SDK 3.10.0

Development

Successfully merging this pull request may close these issues.

Create convenience method to set SpaceInfiltrationDesignFlowRate values from Space

5 participants

@jmarrec @ci-commercialbuildings @kbenne @DavidGoldwasser