Skip to content

Conversation

@shorowit
Copy link
Contributor

Pull request overview

Closes #5469.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@shorowit shorowit self-assigned this Aug 20, 2025
@shorowit shorowit added component - Measures Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Aug 20, 2025
Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say on #5469 that this was a very niche case and we should probably not expose it, but given that the PR is up, so be it, I don't feel strongly and I can't see it creating any problems.

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Aug 21, 2025

CI Results for 2c6227c:

@shorowit
Copy link
Contributor Author

Thanks for fixing my semicolons -- too much ruby these days! 😱

@jmarrec jmarrec merged commit af19df2 into develop Aug 21, 2025
2 of 6 checks passed
@jmarrec jmarrec deleted the osarg_set_required branch August 21, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - Measures Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OSArgument.setRequired() method

4 participants