Skip to content

V25.2.0-IOFreeze: new AFNCoilNames references #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmarrec merged 7 commits into from
Oct 22, 2025
Merged

V25.2.0-IOFreeze: new AFNCoilNames references #5479

jmarrec merged 7 commits into from
Oct 22, 2025

Conversation

@joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Aug 25, 2025 •
edited by jmarrec
Loading

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson self-assigned this Aug 25, 2025
@joseph-robertson joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Aug 25, 2025
@joseph-robertson joseph-robertson mentioned this pull request Aug 25, 2025
Closed
26 tasks
@joseph-robertson joseph-robertson marked this pull request as ready for review October 10, 2025 18:43
Base automatically changed from v25.2.0-IOFreeze to develop October 20, 2025 12:08
jmarrec
jmarrec reviewed Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's some potential inconsistency on the E+ side and a few objects might be missing, but otherwise this looks good to me.

resources/energyplus/ProposedEnergy+.idd
Comment on lines 15145 to 15153
\key Coil:Cooling:WaterToAirHeatPump:EquationFit
\key Coil:Heating:WaterToAirHeatPump:EquationFit
\key Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit
\key Coil:Heating:WaterToAirHeatPump:VariableSpeedEquationFit
Copy link
Collaborator

@jmarrec jmarrec Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually part of 25.1.0:

Copy link
Collaborator

@jmarrec jmarrec Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the E+ IDD perfectly now.

Notice that Coil:Cooling:DX:SingleSpeed:ThermalStorage is not part of that list.

But that object does have \reference AFNCoilNames on it though...

Copy link
Collaborator

@jmarrec jmarrec Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, i think the Coil:XXX:MultiStage are missing the reference AFNCoilNames too

I asked for it:

src/model/AirflowNetworkEquivalentDuct.cpp
Comment on lines +87 to +88
case IddObjectType::OS_Coil_Cooling_DX_SingleSpeed_ThermalStorage:
return std::string("Coil:Cooling:DX:SingleSpeed:ThermalStorage");
Copy link
Collaborator

@jmarrec jmarrec Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is NOT valid per E+ IDD

src/model/AirflowNetworkEquivalentDuct.cpp
Comment on lines 89 to 96
case IddObjectType::OS_Coil_Cooling_WaterToAirHeatPump_EquationFit:
return std::string("Coil:Cooling:WaterToAirHeatPump:EquationFit");
case IddObjectType::OS_Coil_Heating_WaterToAirHeatPump_EquationFit:
return std::string("Coil:Cooling:WaterToAirHeatPump:EquationFit");
case IddObjectType::OS_Coil_Cooling_WaterToAirHeatPump_VariableSpeedEquationFit:
return std::string("Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit");
case IddObjectType::OS_Coil_Heating_WaterToAirHeatPump_VariableSpeedEquationFit:
return std::string("Coil:Heating:WaterToAirHeatPump:VariableSpeedEquationFit");
Copy link
Collaborator

@jmarrec jmarrec Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

But I'm still seeing stuff listed in the E+ AFN:Component:Coil that is NOT in this function

{'Coil:Heating:Electric:MultiStage',
 'Coil:Heating:Gas:MultiStage',
 'Coil:Heating:WaterToAirHeatPump:EquationFit'}

Copy link
Collaborator

@jmarrec jmarrec Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coil:Heating:WaterToAirHeatPump:EquationFit I didn't find because line 92 is a copy paste issue.

@jmarrec jmarrec force-pushed the v25.2.0-IOFreeze-afn branch from cb671df to 04ce630 Compare October 22, 2025 09:00
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Oct 22, 2025 •
edited
Loading

CI Results for 7e7197d:

@jmarrec jmarrec mentioned this pull request Oct 22, 2025
Open
@jmarrec
Copy link
Collaborator

jmarrec commented Oct 22, 2025

Merging for now

@jmarrec jmarrec merged commit 0169ecd into develop Oct 22, 2025
2 of 6 checks passed
@jmarrec jmarrec deleted the v25.2.0-IOFreeze-afn branch October 22, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmarrec jmarrec jmarrec left review comments

Assignees

@joseph-robertson joseph-robertson

Labels

IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joseph-robertson @ci-commercialbuildings @jmarrec