V25.2.0-IOFreeze: ExternalInterface's optional Initial Value field

[joseph-robertson]

Pull request overview

• Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for e4d1e32:

• Ubuntu 24.04:

• Ubuntu 22.04:

• Darwin:

• Windows:

  • OpenStudio-3.10.1-alpha+973d4ffdfa-Windows.exe
  • OpenStudio-3.10.1-alpha+973d4ffdfa-Windows.tar.gz

• Code Coverage:

[jmarrec]

Looks good to me. In case someone wonders why there is no FT change necessary here, it's because the FT is written in old/poor style to begin with and puts everything in an optional already.

OpenStudio/src/energyplus/ForwardTranslator/ForwardTranslateExternalInterfaceFunctionalMockupUnitExportToActuator.cpp

Lines 54 to 57 in 2b0e50e

	d = modelObject.initialValue();
	if (d.is_initialized()) {
	idfObject.setDouble(ExternalInterface_FunctionalMockupUnitExport_To_ActuatorFields::InitialValue, d.get());
	}

OpenStudio/src/energyplus/ForwardTranslator/ForwardTranslateExternalInterfaceFunctionalMockupUnitExportToSchedule.cpp

Lines 49 to 52 in 2b0e50e

	d = modelObject.initialValue();
	if (d.is_initialized()) {
	idfObject.setDouble(ExternalInterface_FunctionalMockupUnitExport_To_ScheduleFields::InitialValue, d.get());
	}

[jmarrec]

Related E+ PR is

• Make ExternalInterface:FunctionalMockupUnitExport:To:Schedule/Actuator Initial Value field optional EnergyPlus#10943

Thanks for remembering to add the API break to the release notes.

[jmarrec]

I'm not 100% sure this is correct on E+ side, asking for clarification in

• Make ExternalInterface:FunctionalMockupUnitExport:To:Schedule/Actuator Initial Value field optional EnergyPlus#10943 (comment)