V25.2.0-IOFreeze: new EvaporativeFluidCooler defaults #5486

joseph-robertson · 2025-09-30T21:45:34Z

Pull request overview

E+ PR: Fix Evaporative Fluid Cooler Table Reports and Add Design Entering Temperature Defaults EnergyPlus#11043

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

…efaults.

joseph-robertson · 2025-10-02T23:37:12Z

resources/model/OpenStudio.idd

+  N4 , \field Heat Rejection Capacity and Nominal Capacity Sizing Ratio
+       \required-field
+       \type real


Need VT because of this change.

Ok, so this is a new field, and E+ has 1.25 as the default.

Well, this is not a new field, I didn't bother going back to the root, but it was already there in V8-6-0.

Not sure why we don't have it?

It was added in OS SDK 1.13.0, which was based on V8.6.0.

That field was added somewhere between E+ V8.0.0 and V8.1.0, so I'm not sure how this happened, but let's just say we don't care, it's just too old to care. Adding it, and moving on

joseph-robertson · 2025-10-08T22:32:16Z

src/model/EvaporativeFluidCoolerSingleSpeed.cpp

    }

+    boost::optional<double> EvaporativeFluidCoolerSingleSpeed_Impl::autosizedDesignEnteringWaterTemperature() const {
+      return getAutosizedValue("TODO", "m3/s");


Need to address this.

joseph-robertson · 2025-10-08T22:32:31Z

src/model/EvaporativeFluidCoolerTwoSpeed.cpp

    }

+    boost::optional<double> EvaporativeFluidCoolerTwoSpeed_Impl::autosizedDesignEnteringWaterTemperature() const {
+      return getAutosizedValue("TODO", "W");


Need to address this.

joseph-robertson · 2025-10-09T21:56:54Z

resources/model/OpenStudio.idd

+  N9 , \field Design Entering Water Temperature
       \type real
       \units C
       \minimum> 0.0
+       \default autosize
+       \autosizable
       \ip-units F
       \note Only used for Performance Input Method = UserSpecifiedDesignCapacity;
       \note for other Performance Input Methods, this field is ignored.
       \note Design Entering Water Temperature must be greater than Design Entering Air Temperature.
-  N9 , \field Design Entering Air Temperature
+  N10, \field Design Entering Air Temperature
       \type real
       \units C
+       \default 35.0
       \minimum> 0.0
       \ip-units F
       \note Only used for Performance Input Method = UserSpecifiedDesignCapacity;
       \note for other Performance Input Methods, this field is ignored.
       \note Design Entering Air Temperature must be greater than Design Entering Air Wet-bulb
       \note Temperature.
-  N10, \field Design Entering Air Wet-bulb Temperature
+  N11, \field Design Entering Air Wet-bulb Temperature
       \type real
       \units C
+       \default 25.6
       \minimum> 0.0
       \ip-units F
       \note Only used for Performance Input Method = UserSpecifiedDesignCapacity;


I feel like these should just be made required. Then our getters are simplified. If so, we need VT rules.

Hum.

So Design Entering Air Temperature / Design Entering Air Wet-bulb Temperature

Only used for Performance Input Method = UserSpecifiedDesignCapacity; for other performance input methods this field is ignored.

That's why we had a reset function before.

…elds.

joseph-robertson · 2025-10-10T17:41:27Z

developer/doc/ReleaseNotes/OpenStudio_Release_Notes_3_11_0_TBD.md

+        * `Design Entering Air Wet-bulb Temperature`
+    * API-breaking changes for `EvaporativeFluidCooler:SingleSpeed` and `EvaporativeFluidCooler:TwoSpeed`:
+        * `designEnteringAirTemperature` and `designEnteringAirWetbulbTemperature` (`boost::optional<double>` to `double`)
+        * `resetDesignEnteringWaterTemperature`, `resetDesignEnteringAirTemperature`, and `resetDesignEnteringAirWetbulbTemperature` are removed


Should these instead be deprecated (to do nothing)? Seems dangerous.

Technically speaking, we could have the reset do the IDD default (autosize, 35.0 and 25.6).

But I think it's confusing. We're already API breaking this object here anyways, so I think it's best to just rip out the band aid right away.

jmarrec · 2025-10-20T10:06:56Z

resources/model/OpenStudio.idd

+  N4 , \field Heat Rejection Capacity and Nominal Capacity Sizing Ratio
+       \required-field
+       \type real


Ok, so this is a new field, and E+ has 1.25 as the default.

jmarrec · 2025-10-20T10:09:37Z

resources/model/OpenStudio.idd

+  N4 , \field Heat Rejection Capacity and Nominal Capacity Sizing Ratio
+       \required-field
+       \type real


Well, this is not a new field, I didn't bother going back to the root, but it was already there in V8-6-0.

Not sure why we don't have it?

jmarrec · 2025-10-20T10:15:20Z

resources/model/OpenStudio.idd

+  N4 , \field Heat Rejection Capacity and Nominal Capacity Sizing Ratio
+       \required-field
+       \type real


It was added in OS SDK 1.13.0, which was based on V8.6.0.

That field was added somewhere between E+ V8.0.0 and V8.1.0, so I'm not sure how this happened, but let's just say we don't care, it's just too old to care. Adding it, and moving on

jmarrec · 2025-10-20T10:23:58Z

resources/model/OpenStudio.idd

+  N9 , \field Design Entering Water Temperature
       \type real
       \units C
       \minimum> 0.0
+       \default autosize
+       \autosizable
       \ip-units F
       \note Only used for Performance Input Method = UserSpecifiedDesignCapacity;
       \note for other Performance Input Methods, this field is ignored.
       \note Design Entering Water Temperature must be greater than Design Entering Air Temperature.
-  N9 , \field Design Entering Air Temperature
+  N10, \field Design Entering Air Temperature
       \type real
       \units C
+       \default 35.0
       \minimum> 0.0
       \ip-units F
       \note Only used for Performance Input Method = UserSpecifiedDesignCapacity;
       \note for other Performance Input Methods, this field is ignored.
       \note Design Entering Air Temperature must be greater than Design Entering Air Wet-bulb
       \note Temperature.
-  N10, \field Design Entering Air Wet-bulb Temperature
+  N11, \field Design Entering Air Wet-bulb Temperature
       \type real
       \units C
+       \default 25.6
       \minimum> 0.0
       \ip-units F
       \note Only used for Performance Input Method = UserSpecifiedDesignCapacity;


Hum.

So Design Entering Air Temperature / Design Entering Air Wet-bulb Temperature

Only used for Performance Input Method = UserSpecifiedDesignCapacity; for other performance input methods this field is ignored.

That's why we had a reset function before.

jmarrec · 2025-10-20T10:26:49Z

resources/model/OpenStudio.idd

+       \required-field
+       \autosizable


Just a side node: IMHO Should probably be \autocalculatable given that it just reads mandatory numeric values from Sizing:Plant

Fix Evaporative Fluid Cooler Table Reports and Add Design Entering Temperature Defaults EnergyPlus#11043 (comment)

Anyways, this field is also

Only used for Performance Input Method = UserSpecifiedDesignCapacity; for other performance input methods this field is ignored.

Hence why we have had a reset function for it as well

src/osversion/VersionTranslator.cpp

jmarrec · 2025-10-20T10:45:42Z

src/energyplus/Test/PlantEquipmentOperationSchemes_GTest.cpp

-  {
-    EvaporativeFluidCoolerTwoSpeed obj(m);
-    EXPECT_EQ(openstudio::energyplus::ComponentType::COOLING, openstudio::energyplus::componentType(obj));
-  }


Why remove this?

It's repeated below (right after EvaporativeFluidCoolerSingleSpeed obj(m)).

jmarrec · 2025-10-20T10:48:20Z

src/energyplus/ForwardTranslator/ForwardTranslateEvaporativeFluidCoolerSingleSpeed.cpp

+    } else if (modelObject.isDesignEnteringWaterTemperatureAutosized()) {
+      idfObject.setString(openstudio::EvaporativeFluidCooler_SingleSpeedFields::DesignEnteringWaterTemperature, "Autosize");


Ok, all good for FT.

Note: generally speaking, I wonder if it's better to only translate choice-dependent fields.
Meaning here, if performance input method is not UserSpecifiedDesignCapacity, should you not translate these Design Temperatures?

Another area where we should probably have guidelines for consistency

@joseph-robertson I filled this, to echo some convos we've had on Slack in the past few months too:

Update/Create internal Guidelines for developpers #5501

jmarrec · 2025-10-20T10:55:20Z

src/energyplus/CMakeLists.txt

+  Test/EvaporativeFluidCoolerSingleSpeed_GTest.cpp
+  Test/EvaporativeFluidCoolerTwoSpeed_GTest.cpp


Thanks for this

jmarrec · 2025-10-20T11:06:06Z

TL;DR right now:

I think I agree with these changes

But I'd like to clarify the autosizedDesignWaterFlowRate thing:

Ensure this value is found in the SQL or flag it properly
update OpenStudio-resources autosize_hvac (either add the object, or make an exclusion with a comment if not found in SQL)

joseph-robertson · 2025-10-22T17:43:14Z

TL;DR right now:

I think I agree with these changes

But I'd like to clarify the autosizedDesignWaterFlowRate thing:

Ensure this value is found in the SQL or flag it properly

update OpenStudio-resources autosize_hvac (either add the object, or make an exclusion with a comment if not found in SQL)

You mean autosizedDesignEnteringWaterTemperature, right?

jmarrec · 2025-10-23T14:21:21Z

Fix #11283 - Evaporative Fluid Coolers cannot have an Autosized Design Entering Water Temperature EnergyPlus#11284

…vap-fluid

ci-commercialbuildings · 2025-10-29T04:24:19Z

CI Results for 6683419:

Ubuntu 24.04:
- OpenStudio-3.11.0-alpha+6683419427-Ubuntu-24.04-x86_64.deb
- OpenStudio-3.11.0-alpha+6683419427-Ubuntu-24.04-x86_64.tar.gz
Ubuntu 22.04:
Darwin:
Windows:
- OpenStudio-3.11.0-alpha+6683419427-Windows.exe
- OpenStudio-3.11.0-alpha+6683419427-Windows.tar.gz
Code Coverage:

joseph-robertson added 4 commits September 30, 2025 14:42

Update EvaporativeFluidCoolerSingleSpeed model methods for new defaults.

1328a38

Update EvaporativeFluidCoolerSingleSpeed idd for new defaults.

8bb21e8

Update EvaporativeFluidCoolerSingleSpeed ft and model tests for new d…

5a7b64e

…efaults.

Formatting.

069e845

joseph-robertson self-assigned this Sep 30, 2025

joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Sep 30, 2025

joseph-robertson mentioned this pull request Sep 30, 2025

Update to EnergyPlus 25.2.0 #5472

Closed

26 tasks

joseph-robertson added 10 commits September 30, 2025 17:03

Update rt file for singlespeed.

1900859

Create a new ft test for EvaporativeFluidCoolerSingleSpeed.

700e67e

Formatting.

e04d44d

Updates for EvaporativeFluidCoolerTwoSpeed.

e8e6fe8

Formatting.

d029635

Typos.

d8c797f

Missing new autosize public method.

3243313

Update idd and ft test files.

113abf6

Update expected values in ft test files.

e075de4

Add missing heat rejection field for singlespeed.

d9c525e

joseph-robertson commented Oct 2, 2025

View reviewed changes

joseph-robertson added 2 commits October 3, 2025 10:27

Add vt for new heat rejection field.

15ca8e8

Update the vt test for EvaporativeFluidCoolerSingleSpeed.

9495327

joseph-robertson commented Oct 8, 2025

View reviewed changes

joseph-robertson added 2 commits October 8, 2025 15:35

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-evap-fluid

6b52074

Stub new autosized value names.

32819fa

joseph-robertson commented Oct 9, 2025

View reviewed changes

joseph-robertson added 5 commits October 9, 2025 15:32

Make new EvaporativeFluidCooler fields with defaults into required fi…

fac0052

…elds.

Fix vt rule.

e2e9558

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-evap-fluid

7d0322e

Update release notes.

d13ae9f

Clean up the vt rule.

6254d7d

joseph-robertson commented Oct 10, 2025

View reviewed changes

joseph-robertson added 2 commits October 10, 2025 15:14

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-evap-fluid

a11bfcf

Fix vt test.

3baab67

joseph-robertson marked this pull request as ready for review October 16, 2025 16:10

jmarrec reviewed Oct 20, 2025

View reviewed changes

VT emplace_back + move

4ccb0ff

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-evap-fluid

86011fc

Base automatically changed from v25.2.0-IOFreeze to develop October 20, 2025 12:08

Merge branch 'develop' into v25.2.0-IOFreeze-evap-fluid

d5768ef

jmarrec added 2 commits October 24, 2025 18:30

Rename to 3_11_0 before trying to merge develop

8ada48b

Merge remote-tracking branch 'origin/develop' into v25.2.0-IOFreeze-e…

c37a3fc

…vap-fluid

jmarrec force-pushed the v25.2.0-IOFreeze-evap-fluid branch from 0745cc6 to c37a3fc Compare October 24, 2025 16:31

Merge branch 'develop' into v25.2.0-IOFreeze-evap-fluid

873e572

joseph-robertson changed the base branch from develop to v25.2.0-RC1 October 29, 2025 03:59

Merge branch 'v25.2.0-RC1' into v25.2.0-IOFreeze-evap-fluid

6683419

Base automatically changed from v25.2.0-RC1 to develop October 29, 2025 17:30

joseph-robertson merged commit fdff733 into develop Oct 29, 2025
0 of 4 checks passed

joseph-robertson deleted the v25.2.0-IOFreeze-evap-fluid branch October 29, 2025 17:31

		} else if (modelObject.isDesignEnteringWaterTemperatureAutosized()) {
		idfObject.setString(openstudio::EvaporativeFluidCooler_SingleSpeedFields::DesignEnteringWaterTemperature, "Autosize");

		Test/EvaporativeFluidCoolerSingleSpeed_GTest.cpp
		Test/EvaporativeFluidCoolerTwoSpeed_GTest.cpp

V25.2.0-IOFreeze: new EvaporativeFluidCooler defaults #5486

V25.2.0-IOFreeze: new EvaporativeFluidCooler defaults #5486

Conversation

joseph-robertson commented Sep 30, 2025 • edited by jmarrec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Pull Request Author

Review Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmarrec Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmarrec commented Oct 20, 2025

Uh oh!

joseph-robertson commented Oct 22, 2025

Uh oh!

jmarrec commented Oct 23, 2025

Uh oh!

ci-commercialbuildings commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joseph-robertson commented Sep 30, 2025 •

edited by jmarrec

Loading

jmarrec Oct 20, 2025 •

edited

Loading

ci-commercialbuildings commented Oct 29, 2025 •

edited

Loading