Fix: Properly construct a dgsDataLoaderReloadController #2204
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berngp
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
The `reloadableDgsDataLoaderProvider` must return an instance of `ReloadableDgsDataLoaderProvider` instead of the more generic `DgsDataLoaderProvider` such that the `dgsDataLoaderReloadController` can be constructed. This commit addresses the issue above as well as ads test to confirm the proper patterns with and without the dgs.reload flag enabled.
berngp
force-pushed
the
feature/reload-data-loader
branch
from
9d87025 to
4b4309e
Compare
berngp
changed the title
iparadiso
approved these changes
Aug 21, 2025
Contributor
Author
|
Thanks @iparadiso |
paulbakker
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
The
reloadableDgsDataLoaderProvidermust return an instance ofReloadableDgsDataLoaderProviderinstead of the more genericDgsDataLoaderProvidersuch that thedgsDataLoaderReloadControllercan be constructed.This commit addresses the issue above as well as adds tests to confirm the beans are available, or not, with and without the
dgs.reloadflag enabled.