Skip to content

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Nov 16, 2020

Description

Swish and Mish activation functions.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@rijobro rijobro requested review from Nic-Ma, ericspod and wyli and removed request for ericspod November 16, 2020 12:55
Signed-off-by: Richard Brown <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you please also update monai/networks/blocks/__init__.py with the new classes? and perhaps docs/source/networks.rst

@rijobro
Copy link
Contributor Author

rijobro commented Nov 16, 2020

@wyli done, thanks!

@wyli
Copy link
Contributor

wyli commented Nov 16, 2020

/integration-test
(testing the integration command)

@wyli wyli merged commit 8bbdc41 into Project-MONAI:master Nov 16, 2020
@bhashemian
Copy link
Member

It seems that it the integration command works! Yay! But please let me know if you find any problem with that.

@rijobro rijobro deleted the activations branch November 17, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants