Skip to content

Fix value mapper for NEXRAD DPR product #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcamron merged 1 commit into from
Apr 20, 2022
Merged

Fix value mapper for NEXRAD DPR product #2442

dcamron merged 1 commit into from
Apr 20, 2022

Conversation

@dopplershift
Copy link
Member

@dopplershift dopplershift commented Apr 19, 2022

Description Of Changes

One of the threshold blocks had a value of 65535, which got interpreted as -1--thus breaking our construction of the lookup table.

Checklist

  • Closes #xxxx
  • Tests added
  • Fully documented

@dopplershift
BUG: Fix value mapper for DPR product
8c964b9 
One of the threshold blocks had a value of 65535, which got interpreted
as -1--thus breaking our construction of the lookup table.
@dopplershift dopplershift added Type: Bug Something is not working like it should Area: IO Pertains to reading data labels Apr 19, 2022
@dopplershift dopplershift added this to the May 2022 milestone Apr 19, 2022
@dopplershift dopplershift requested a review from a team as a code owner April 19, 2022 02:47
@dopplershift dopplershift requested review from dcamron and removed request for a team April 19, 2022 02:47
dcamron
dcamron approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned of (or recalled) the Unidata conda channel while double-checking some background on this one 😁

Looks good 👍

@dcamron dcamron merged commit 2471128 into Unidata:main Apr 20, 2022
@dopplershift dopplershift deleted the fix-nexrad-dpr branch April 20, 2022 20:32
@dopplershift dopplershift added the backport Pull Requests that are automatically back-ported to the stable release label Jun 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

🚨 Unable to cleanly backport this PR! 🚨

@dopplershift dopplershift added backport Pull Requests that are automatically back-ported to the stable release and removed backport Pull Requests that are automatically back-ported to the stable release labels Jun 30, 2022
@github-actions github-actions bot mentioned this pull request Jun 30, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

🏁 Successfully backported as #2567. 🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcamron dcamron dcamron approved these changes

Assignees

No one assigned

Labels

Area: IO Pertains to reading data backport Pull Requests that are automatically back-ported to the stable release Type: Bug Something is not working like it should

Projects

None yet

Milestone

May 2022

Development

Successfully merging this pull request may close these issues.

2 participants

@dopplershift @dcamron