adds RGB image ability to declarative #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Would it be better to avoid the flag and instead just allow 3D + last dimension size 3 or 4? |
Collaborator
Author
|
Okay, I think I have a way to allow the 3D data without need of an extra attribute, which would be an extra pain. I think I modified the test that should cover the new behavior, but we'll see. |
kgoebber
force-pushed
the
rgb_image_declarative
branch
from
52ba53c to
e0d9b09
Compare
dopplershift
requested changes
May 3, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Really just kicking back because of the error message change, but found a few other minor tweaks...
kgoebber
force-pushed
the
rgb_image_declarative
branch
from
e0d9b09 to
4d90e63
Compare
kgoebber
force-pushed
the
rgb_image_declarative
branch
from
4d90e63 to
2064648
Compare
dopplershift
approved these changes
May 4, 2022
dopplershift
added
Type: Bug
dopplershift
added
the
backport
Contributor
|
🏁 Successfully backported as #2569. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR adds a new attribute to the declarative syntax to indicate the plotting of an RGB image through a boolean setting. This preserves the check for 2D for all data, adds new check for if
rgb_imageis set toTrueand check to ensure it is 3D.Open to suggestions on naming and description of attribute.
Checklist