Fix image tests #2492
Merged
Fix image tests #2492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Maintenance
dopplershift
force-pushed
the
fix-image-tests
branch
from
b53119d to
2fd74bd
Compare
dcamron
requested changes
May 25, 2022
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Thanks for coming back to this.
Looks like Natural Earth tweaked some lake boundaries. Update some tests to remove maps if they're not unique to those tests, otherwise just bump the test image.
dopplershift
force-pushed
the
fix-image-tests
branch
from
2fd74bd to
b661ea6
Compare
dopplershift
added
the
manual backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Looks like Natural Earth tweaked some lake boundaries. Update some tests to remove maps if they're not unique to those tests, otherwise just bump the test image.
Also fixed some duplicated test docstrings as well as a test that was missing the image comparison decorator 😬 (and added an image that seems reasonable).
Replaces and closes #2487.
Checklist
[ ] Fully documented