Improve the docs for Bunkers storm motion #2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Docs
dcamron
requested changes
Jun 2, 2022
dopplershift
force-pushed
the
bunkers-docs
branch
from
cb52257 to
111853f
Compare
Member
Author
|
I took a swing at cleaning them up, let me know what you think. |
dcamron
approved these changes
Jun 3, 2022
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
This is definitely an improvement. It's difficult to boil some of this terminology down effectively, but I think this is in a good spot.
Member
Author
|
Yeah, I don't love all of the terminology in there, but I pulled it all from the original paper--and I haven't tried to fully understand the technique enough to rewrite the things in simpler terms. |
Member
|
Sounds reasonable to me 👍 |
dopplershift
added
the
backport
Contributor
|
🏁 Successfully backported as #2571. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Add a bit more of the description of the approach (taken from the original paper) and also clarify the inputs.
Checklist
Tests added