Add SWEAT Index calculate function. #2580
Conversation
C2oWisComing
left a comment
C2oWisComing
left a comment
There was a problem hiding this comment.
Add SWEAT Index calculate function.
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Apologies on it taking so long to review this, but as we get ready for a new release, it'd be great to get this in.
If you don't mind, I'd prefer to use one of our existing references than continue to expand the list, just to keep things simple.
I also made some suggestions that make the implementation more robust towards units and made it possible that it might work with grids (and eliminated some conditions that weren't checked by tests).
dopplershift
added
Type: Feature
|
Thank you for your kind review. I will fix it all asap. |
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
A few more suggested changes. The change to the calculation somehow got missed and not included in my last review (oops). The changes to the docstring should fix the linting errors.
|
Hrmmm...we're hitting a |
|
Thank you I really appreciate your help. |
This is still well-within our window and fixes a RecursionError in the SWEAT test due to adding a numpy scalar to a dimensionless quantity.
dopplershift
force-pushed
the
add-sweat-index
branch
from
d5db386 to
9773d8d
Compare
2 participants
Description Of Changes
Add a function for SWEAT Index calculation based on this formula:
SWEAT = 12Td850 + 20(TT - 49) + 2f850 + f500 + 125(S + 0.2)
Test data from http://weather.uwyo.edu/cgi-bin/sounding?region=seasia&TYPE=GIF%3ASKEWT&YEAR=2021&MONTH=09&FROM=1700&TO=1700&STNM=48453
Checklist