Adds ArrowPlot to declarative #2644
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @needs_cartopy | ||
| def test_declarative_arrowplot(): | ||
| """Test making a arrow plot.""" | ||
| data = xr.open_dataset(get_test_data('narr_example.nc', as_file_obj=False)) |
Check warning
Code scanning / CodeQL
File is not always closed
| @needs_cartopy | ||
| def test_declarative_arrowkey(): | ||
| """Test making a arrow plot with an arrow key.""" | ||
| data = xr.open_dataset(get_test_data('narr_example.nc', as_file_obj=False)) |
Check warning
Code scanning / CodeQL
File is not always closed
| @needs_cartopy | ||
| def test_declarative_arrow_changes(): | ||
| """Test making a arrow plot with an arrow key.""" | ||
| data = xr.open_dataset(get_test_data('narr_example.nc', as_file_obj=False)) |
Check warning
Code scanning / CodeQL
File is not always closed
|
It appears I don't have the correct version of FreeType to conform to our CI processes. Trying to search for ways to get the M1 chip to have freestyle 2.6.1. Earliest version via conda would be 2.10.4 - haven't been able to find a pip wheel that might work either...a little out of my depth on this one. |
|
😒 This macOS ARM64 + Freetype issue is going to become a problem. Luckily there's on-going work to introduce perceptual image hashing in pytest-mpl that should eliminate the need. (Otherwise I have no idea what to do unless matplotlib bumps their testing version of freetype.) I'll regenerate the images from the PR and upload. |
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks good overall, just a suggestion of a better way to generate the arrowkey.
kgoebber
force-pushed
the
add_arrow_plot
branch
from
74f33e5 to
762d97c
Compare
|
I think my latest addition blew away the updated figures you added. Didn't find the correct incantation to grab those as part of my local PR...a bit out of my git-league. |
|
For future reference, a |
dopplershift
force-pushed
the
add_arrow_plot
branch
from
dd429b6 to
9aa9704
Compare
This removes problems with Tuple(allow_none=True, default_value=None).
dopplershift
force-pushed
the
add_arrow_plot
branch
from
9aa9704 to
5db93dc
Compare
dopplershift
added
Type: Feature
|
@kgoebber I managed to get the testing builds for matplotlib on conda-forge to build for osx-arm64. So if you update the environment (and it's configured to use |
|
Excellent. I’ve just installed and is working well. I see the few images that need updating, but exciting that it is working for the M1 chip now! Thanks for that effort.
|
2 participants
Description Of Changes
This PR adds a new feature to plot arrows (quivers) to the declarative syntax. Kept the implementation basic in terms of options to change and hardest part was coming up with a reasonable way to add a quiverkey. Open to suggestions for improvement on any part, but especially the key portion.
Checklist