catch metar visibility with zero denominator #2653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrherz
force-pushed
the
gh2652_metar_vis_divzero
branch
from
9be1015 to
d5c7df9
Compare
dopplershift
approved these changes
Sep 8, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Thanks for contributing the fix and the test!
dopplershift
added
Type: Bug
Member
|
I think this is the right approach. The PEG parser is a pattern matcher to pull apart the report. For better or worse, 0 in the denominator is a valid pattern. Canopy, as far as a I know, doesn't give use the ability to "skip" pieces of the report, so we need to make sure we're grabbing everything as we scan through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Prevents an invalidly encoded visibility with a 0 denominator from tripping up the METAR parser. For example:
Visibility is
np.nanin this case.Checklist
PS. I attempted to adjust the PEG parser to require a non-zero denominator, but that has a side effect of causing the entire METAR parsing to fail, so the valid cloud, temp, and pressure data is lost.