Fix resolution of grids generated by interpolate #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
There was an off-by-one error in calculating the number of grid points needed to meet the desired resolution. The previous code calculated the number of steps, but did not include the starting point. In order to avoid regenerating test data, the specified resolution in the test was adjusted to match that actually given before.
dopplershift
force-pushed
the
fix-2319
branch
from
ad1b88a to
5fa5ab7
Compare
dcamron
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
interpolate_to_grid, due to an off-by-one error, was not actually generating grids with the requested resolution. Instead, they had one fewer point than that needed to generate the requested resolution. The previous implementation calculated the number of steps needed, but essentially omitted the starting point.In order to avoid regenerating a bunch of test data, I adjusted the test to request a resolution matching the previous reality.
This also cleans up the documentation for some of those internal functions.
Checklist