Bump image threshold #2805
Merged
Bump image threshold #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like running against numpy 1.24.0rc1 has tweaked the starting point of the barbs by a pixel. Just bump the threshold here.
dopplershift
added
Type: Maintenance
Collaborator
|
Agreed. |
kgoebber
approved these changes
Nov 29, 2022
Member
Author
|
@kgoebber You can click the green button 😉 |
Collaborator
|
It says I am not authorized to merge the PR - otherwise I would! |
Member
Author
|
Can you check now? |
Collaborator
|
All good now. |
Member
Author
|
I apparently had a couple things locked down that were not working as I intended. Confusing sometimes because you merging a PR counts as a "push" to main, even though I don't think of it that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like running against numpy 1.24.0rc1 has tweaked the starting point of the barbs by a pixel. Just bump the threshold here.
Description Of Changes
Checklist