Ensure degree units by default for lat/lon in xarray #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
We intentionally want to assume degrees for our various lat/lon handling with e.g.
lat_lon_grid_deltas, but for xarray we by default were giving 'dimensionless' units when no unit attribute is present (which can happen when attributes are dropped by various xarray functionality).See also #2811, #2836, and #2848.
The solution here ended up being more clean than I feared. (cc @jthielen)
Checklist
lat_lon_grid_deltas(and in turn xarray grid argument magic) fails silently on xarray input with missing lat/lon units due to incorrect unit conversion #2028