-
Notifications
You must be signed in to change notification settings - Fork 443
Update areas #2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update areas #2949
Conversation
d658557 to
70f7473
Compare
8f478c2 to
f5fe981
Compare
|
I'll start looking at a named tuple for creating the areas and if there are any resources you want to point me toward for being able to auto generate the documentation file, I would be very happy to entertain. Any other thoughts about functionality or organization of the information/documentation? |
2ffba12 to
7248c6d
Compare
|
Okay, so I've updated this PR with what ended up being a very simple way of generating the area.rst file to both make files. I removed the committed area.rst and we should be relying on the autogenerated one from the Python file. |
|
Would you mind test out using If you find yourself needing to hand this off, I can dig into that, but it could let us keep your script as part of our sphinx tooling and out of the separate |
|
Okay, couldn't find a way with a more specific sphinx way of creating the |
|
I've got the best path to integrate with Sphinx here figured out. I'll push some changes to this PR. |
|
So this isn't much different than what was done (running inside Other than that it's the same code, though it relies on Sphinx to know some proper paths and give us a logger. Sphinx doesn't have much better in the way of hooks to grab, but this does seem a bit more structured than running a script every time |
|
@dcamron This will need your review since I've now committed on the PR. |
dopplershift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, finally noticed a few things here.
If you can't get to them before (trying to) release tomorrow, I'll take care of them.
f4e196c to
62df8de
Compare
|
I was able to make the requested changes, but don't have the correct method of exposing the |
This changes things minimally, but hooks into the Sphinx build process in a more structured way. This allows getting the build directory more robustly and allows us to use Sphinx logging, as well as generating at a better time than doing the build every time conf.py is imported/run.
Since building the full area file can take awhile with all the plots, add a config to control it. By default, we only build the full file on CI.
|
I confirmed that the default to dynamically control whether we generate ALL the areas is working properly on CI vs. locally. This is a significant time savings for building locally (when you don't actually care about having them all). |
dcamron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks y'all for getting this all there!
Description Of Changes
This is a first pass at updating the ways that the areas baked into the declarative syntax works. I've captured 331 areas (a subset of what was in our original list) and have them corresponding to both an extent and a Cartopy projection. This is all contained in a separate file now and removed from the declarative file. These areas, their extents, and the projections are also available outside of the declarative syntax as well, which is captured the tutorial.
In adding elements to the docs I've attempted to capture things in a tutorial as well as a separate listing of all of the areas with a graphical representation of those areas with their long descriptive name. This generates 331 images, so the build of the docs takes longer, but if the file is not changed, then the caching of the images works as intended.
Still to do is to add tests.
Open to suggestions about organization of any of this material.
Checklist