Fix fronts #3098
Merged
Fix fronts #3098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elminate plumbing in the gc to get the step size since Front now adjusts for linewidth. Instead, add an option to control whether symbols are filled. This removes some static analysis complaints about Dryline overriding methods but using a different signature.
This makes the orientation match that expected by the WPC analyzed fronts, and allows a correct plot to be made with no manual flipping.
dopplershift
added
Type: Bug
dcamron
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This fixes the orientation of
StationaryFrontto match the order from WPC output and fixes the apparent "flipped fronts" (#3047). This also refactors a bit so thatDrylinecan just rely onFrontand not override so much; this fixes some issues flagged by CodeQL (#3043).Checklist