fix mlcape if parcel_start_pressure != bottom #3147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This all looks good to me. |
dopplershift
requested changes
Nov 8, 2023
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Just a minor change and I'm happy for this to go in.
dopplershift
added
Type: Bug
dopplershift
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user calls
mixed_layer_cape_cinand provides aparcel_start_pressurekwarg where the pressure provided is not the surface, then when the pressure of the mixed layer parcel gets appended to the pressure array, pressure is no longer monotonically decreasing. This raises an exception when computing the LCL.This PR trims out any area beneath the provided start pressure, since it isn't used in the CAPE/CIN calculation anyway, and this prevents the pressure from increasing-then-decreasing.