METAR/Station Plot fixes #3297
Merged
METAR/Station Plot fixes #3297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attach a copy of the dictionary of units to the DataFrame so that units can be modified in-place without affecting future calls.
For modern Python, we can just use the 'z' format option. For earlier Python versions, we need to manually round and add a positive 0 to the result to clear the negative 0.
dopplershift
added
Type: Bug
Member
Author
|
Didn't think to run all tests locally, but it turns out some of our declarative tests were indeed plotting '-0', and this changes that. Need to update the images... |
kgoebber
approved these changes
Nov 30, 2023
Collaborator
kgoebber
left a comment
kgoebber
left a comment
There was a problem hiding this comment.
Looks good to me. I never really minded the -0, but can understand that it is a bit awkward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Main thrust is fixing #3296, by adjusting our default formatter for
plot_parameter()to use'z.0f'to avoid'-0'(and an appropriate workaround on Python < 3.11).Also fix an issue I noticed while digging in, where the units dictionary on the parsed
DataFramein our METAR code is a fixed instance; natural in-place modification of this dictionary (e.g.df.units['air_temperature'] = 'degF') would affect all other instances (past and future). We can avoid this by making sure returnedDataFrames get a copy instead.Checklist