return heat_index with temperature units #3307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rwalton91
force-pushed
the
heat-index-issue-3299
branch
2 times, most recently
from
94467be to
6ca06fb
Compare
rwalton91
force-pushed
the
heat-index-issue-3299
branch
from
6ca06fb to
d9b68b9
Compare
dopplershift
reviewed
Dec 7, 2023
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Overall the changes look good, just a minor question about placement.
dopplershift
added
Type: Enhancement
dopplershift
approved these changes
Dec 11, 2023
Member
|
Thanks for the contribution! 🎉 Hope to see you around in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request updates the heat_index calculation to return the same units as the temperature used in the calculation. This change ensures parity across similar equations like wind_chill and apparent_temperature where the return value has the same units as the input temperature.
Checklist