Fix interpolate_to_slice unit handling #3347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
The fixup in Unidata#3255 inadvertently added unit parsing to all code paths in interpolate_to_slice. This breaks any usages that passed in data with unknown units. Since interpolate_to_slice has no need to do any unit handling, avoid this unless we're actually given a quantity.
dcamron
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The fixup in #3255 inadvertently added unit parsing to all code paths in
interpolate_to_slice. This breaks any usages that passed in data with unknown units, such as dBZ with pyart. Sinceinterpolate_to_slicehas no need to do any unit handling, avoid this unless we're actually given a quantity.Also update
.gitignorefor a new file being spit out by sphinx-gallery (or at least new outside the existing ignored directories).Checklist