Fix Plot Geometry Colorfills #3355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dopplershift
reviewed
Jan 9, 2024
dopplershift
added
Type: Bug
dopplershift
approved these changes
Jan 10, 2024
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks great! Glad the fix was simple and easy to make sense of. Thanks for fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR is an attempt to fix #3344 by moving the setting of
kwargsinto the loop and with a copy of the values used formpl_args. This will allow the documented behavior of havingmpl_argsbe the commanding version of any keyword argument in the declarative plotting. I've added a test to cover the multiple fill and stroke values.Checklist