New PlotSurfaceAnalysis class to plot WPC surface analysis bulletins #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
requested changes
Jul 25, 2024
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looking good! Just a few minor changes to get this solid for inclusion.
Contributor
Author
|
"Biggest" change from last commit was changing the default strength_offset. It is then scaled by multiplying by 0.8*label_fontsize |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| pc.draw() | ||
|
|
||
| return pc.figure | ||
|
|
Check warning
Code scanning / CodeQL
File is not always closed
| ps.label_fontsize = 15 | ||
| ps.TROF_linewidth = 5 | ||
| ps.strength_offset = (0,1) | ||
|
|
Check warning
Code scanning / CodeQL
File is not always closed
Scattertext supports same config with TextCollection under the hood, and has hack for bbox clipping with cartopy. Fix style.
…MetPy into plot-bulletin-class
dcamron
reviewed
Jul 31, 2024
anacmontoya
changed the title
dopplershift
approved these changes
Aug 28, 2024
dopplershift
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Added new class to plot the WPC surface bulletins that have been parsed using
parse_wpc_surface_bulletin()function.Some documentation has been added but may need some edits. Currently working on tests.
Checklist