Skip to content

Conversation

@axtloss
Copy link
Contributor

@axtloss axtloss commented Nov 20, 2024

Adds support for defining more than one source in the meson and make plugins as well as some improvements in systemd-sysext

@axtloss axtloss requested a review from mirkobrombin November 20, 2024 08:46
@taukakao
Copy link
Member

taukakao commented Nov 20, 2024

Having a different syntax for the sources field in just this module seems very inconsistent thus counter intuitive.

Would an "additionalSources" field or something work here? That would also not require a breaking change in the vib syntax.

@axtloss
Copy link
Contributor Author

axtloss commented Nov 20, 2024

Having a different syntax for the sources field in just this module seems very inconsistent thus counter intuitive.

what do you mean? that's already a thing in the shell module and this pr adds it to the rest

@taukakao
Copy link
Member

that's already a thing in the shell module and this pr adds it to the rest

I see. But should it then not also be added for the go and apt plugins for example?

@axtloss
Copy link
Contributor Author

axtloss commented Nov 20, 2024

apt possibly yes.
not go though, all it does is compile a binary using go and install it, any extra files couldn't even be used by the plugin, with the meson, make and shell command they can

@taukakao
Copy link
Member

Fair enough. I think it should be as consistent as possible, of course excluding plugins which it doesn't make sense for.

@axtloss axtloss force-pushed the feat/plugin-improvements branch from b73b5de to 1de7a9a Compare January 5, 2025 07:30
@axtloss
Copy link
Contributor Author

axtloss commented Jan 5, 2025

The apt plugin now also supports specifying multiple sources, I changed the logic for loading packages from a file a bit to specify the file directly instead of a path, since it makes no sense to specify a directory if it's possible to specify multiple sources manually

@axtloss axtloss merged commit 3a71c66 into main Jan 9, 2025
3 checks passed
@axtloss axtloss deleted the feat/plugin-improvements branch January 9, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants