Skip to content

Conversation

@NN708
Copy link
Member

@NN708 NN708 commented Mar 15, 2025

Resolves #142.

Copy link
Contributor

@axtloss axtloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Compile shouldn't allow forcing an architecture since it requires extra setup to have podman/docker also build on that architecture.

@NN708
Copy link
Member Author

NN708 commented Mar 15, 2025

the Compile shouldn't allow forcing an architecture since it requires extra setup to have podman/docker also build on that architecture.

Fixed.

@axtloss
Copy link
Contributor

axtloss commented Mar 15, 2025

Please also update the other plugins

@NN708
Copy link
Member Author

NN708 commented Mar 15, 2025

It appears that most of these plugins are designed to accept either one source or none at all, meaning they would fail if the architecture doesn't match, regardless of only-arches. The only exceptions are the make and meson plugins.

@axtloss
Copy link
Contributor

axtloss commented Mar 15, 2025

Yes that's right, these modules shouldn't add any commands if the sources dont match

@mirkobrombin
Copy link
Member

mirkobrombin commented Apr 7, 2025

Can we merge this?

@axtloss axtloss merged commit c744e2d into Vanilla-OS:main Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add only-arches option

3 participants