Fix missing ABSPATH checks in Speculation Rules plugin

[felixarntz]

Summary

The speculation-rules plugin was missing the defined( 'ABSPATH' ) checks that are sort of mandatory for plugins.

Checklist

• PR has either [Focus] or Infrastructure label.
• PR has a [Type] label.
• PR has a milestone or the no milestone label.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: thelovekesh <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[westonruter]

I thought the root .gitattributes was updated to account for these standalone plugin development files. The initial / was removed from the relevant paths so that the files are excluded anywhere in the directory tree. (As I recall. Currently AFK and can't easily confirm.)

[westonruter]

Maybe I'm thinking of what was done in #1011.

[felixarntz]

@westonruter

I thought the root .gitattributes was updated to account for these standalone plugin development files. The initial / was removed from the relevant paths so that the files are excluded anywhere in the directory tree. (As I recall. Currently AFK and can't easily confirm.)

I initially thought this would do it, but missed to consider the important part: To publish the plugins (just like for the modules) the 10up deploy script is instructed to look at the specific plugin folder. So it'll basically be as if the root .gitattributes doesn't exist, so we need those individual ones. It's still not a bad idea to make the root exclusions more generic, but I don't think it's sufficient for this.

This is similar to my #1011 review I just left. cc @thelovekesh

[thelovekesh]

@felixarntz please check my comment here - #1011 (comment)

Since we are passing BUILD_DIR for standalone plugins, I don't think the 10up deploy script will take plugin-specific .gitattributes into account as per - https://github.com/10up/action-wordpress-plugin-deploy/blob/abb939a0d0bfd01063e8d1933833209201557381/deploy.sh#L149

[thelovekesh]

To produce plugin builds, please also refer to #1008, which introduces Webpack (extending WP Script configs) and is capable of handling almost every use case.

This allows us to keep utilizing a single global .distignore file rather than several ignore files. It may also generate any plugin build with a single command, such as this one (which is presently limited to the main plugin):

npm run build-plugin -- --env plugin=perflab # Build the main plugin
npm run build-plugin -- --env plugin=speculation-rules # Build the speculation-rules plugin

[felixarntz]

@thelovekesh Great point. Let's continue the discussion on how we want to solve this problem in #1008, given neither .gitattributes nor .distignore work.

I've removed that part from this PR, so it should be good to go, only focusing on the ABSPATH checks now.

[thelovekesh]

@felixarntz SGTM. Just out of curiosity, I wanted to know where .distignore is causing the issues. AFAIK it's just an ignore file that contains some patterns and is mostly used by multiple tools out there to ignore such patterns from distribution, because .gitignore and .gitattributes are bound to git specific things.

[thelovekesh]

LGTM 🚀