Skip to content

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jun 10, 2022

Summary

webp_uploads_generate_additional_image_source() introduce in version 1.0.0 in the plugin but it still shows @since n.e.xt because of it has text issue. This version change is part of the release process that happens on the day of the release as per https://github.com/WordPress/performance/blob/trunk/docs/Releasing-the-plugin.md#preparing-the-release document.

This PR set the version number to 1.0.0

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mxbclang mxbclang added Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken Needs Review no milestone PRs that do not have a defined milestone for release and removed Infrastructure Issues for the overall performance plugin infrastructure labels Jun 10, 2022
@mxbclang
Copy link
Contributor

Thanks @mukeshpanchal27! Note that per the checklist in the PR template, all PRs require:

  1. Either a [Focus] or Infrastructure label
  2. A [Type] label
  3. Either a set milestone or a "no milestone" label – typically @felixarntz is responsible for assigning milestones, so "no milestone" is the best choice for any new issues

I've added these on this PR, but please make sure you have these added on future PRs as they will not pass tests unless these requirements are met. There are more details on each of the label types in our Handbook if you need them. Thanks!

Copy link
Member

@mitogh mitogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jjgrainger jjgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Great catch!

@felixarntz felixarntz merged commit 9292ebf into WordPress:trunk Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants