Fixed linting issues #707
Merged
Fixed linting issues #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
approved these changes
Jul 21, 2025
Collaborator
kasparsd
left a comment
kasparsd
left a comment
There was a problem hiding this comment.
Thank you so much @sudar! This look great!
Do you know if this completely fixes #437? Can we enable the lint checks now?
two-factor/.github/workflows/test.yml
Line 57 in b27381a
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed linting issues.
Why?
There were lot of linting issues especially in tests. This PR fixed some of these issues and also excludes security related sniffs from tests.
Changelog Entry
Fixed - Linting issues in code