-
-
Notifications
You must be signed in to change notification settings - Fork 33
Implement support for the free-threaded build of CPython 3.13 #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- This requires Cython nightly, so build configs have been changed to accomodate that. - Reverted some of the changes that weren't related to free-threading
for more information, see https://pre-commit.ci
|
If someone could hit |
|
CI Run. If you need me to start it, feel free to reach out on discord or matrix as I likely won't see GitHub notifications as they tend to be overwhelming |
c52c18c to
f8fb0b6
Compare
for more information, see https://pre-commit.ci
|
I changed the approach here to use C++ atomics instead of critical sections. That should be faster / more scalable. If you can hit the green button again for the actions to run, that'd be great!
Not sure what Discord server you're talking about. I'd love an invitation if possible. |
aio-libs uses Matrix https://matrix.to/#/#aio-libs:matrix.org However I'm usually a lot easier to find on Home Assistant's Discord: https://discord.com/invite/home-assistant |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 96.94% 96.22% -0.73%
==========================================
Files 16 14 -2
Lines 1278 1139 -139
Branches 90 90
==========================================
- Hits 1239 1096 -143
- Misses 14 17 +3
- Partials 25 26 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is ready for another round of reviews, whenever anyone finds some spare cycles. |
bdraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. PR description needs to be updated to reflect the changes.
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing that bothers me.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
bdraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lysnikolaou
What do these changes do?
frozen.Are there changes in behavior for the user?
No.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.