Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Aug 29, 2024

We can now use the GCS testbench even if we are testing a Python version that does not support it.

@github-actions
Copy link

⚠️ GitHub issue #43883 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Aug 29, 2024
@pitrou
Copy link
Member Author

pitrou commented Aug 29, 2024

@github-actions crossbow submit wheel-manylinux-2014-cp38-amd64 wheel-manylinux-2014-cp38-arm64 wheel-manylinux-2014-cp313-amd64 wheel-manylinux-2014-cp313-arm64 wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64

@github-actions

This comment was marked as outdated.

@pitrou

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou pitrou force-pushed the gh43883-gcs-testbench-py-version branch from 8fc4c1d to d8cd7cf Compare August 29, 2024 08:56
@pitrou
Copy link
Member Author

pitrou commented Aug 29, 2024

@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64

@github-actions

This comment was marked as outdated.

@pitrou pitrou force-pushed the gh43883-gcs-testbench-py-version branch from d8cd7cf to 0f522cd Compare August 29, 2024 09:04
@pitrou
Copy link
Member Author

pitrou commented Aug 29, 2024

@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64

@github-actions

This comment was marked as outdated.

@pitrou pitrou force-pushed the gh43883-gcs-testbench-py-version branch from 0f522cd to ea00794 Compare August 29, 2024 09:38
@pitrou
Copy link
Member Author

pitrou commented Aug 29, 2024

@github-actions crossbow submit wheel-macos wheel-linux

@pitrou
Copy link
Member Author

pitrou commented Aug 29, 2024

@github-actions crossbow submit -g cpp -g python -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou pitrou marked this pull request as ready for review August 29, 2024 10:50
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 29, 2024
@pitrou pitrou force-pushed the gh43883-gcs-testbench-py-version branch from ea00794 to 9118ef1 Compare September 2, 2024 16:00
@pitrou
Copy link
Member Author

pitrou commented Sep 2, 2024

@github-actions crossbow submit -g cpp -g python

@pitrou
Copy link
Member Author

pitrou commented Sep 2, 2024

@github-actions crossbow submit wheelmacos wheellinux

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

Revision: 9118ef1

Submitted crossbow builds: ursacomputing/crossbow @ actions-a6eb850120

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0-numpy-1.19 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest-numpy-latest GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-cpp GitHub Actions
test-cuda-python GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-20.04-python-3 GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

Revision: 9118ef1

Submitted crossbow builds: ursacomputing/crossbow @ actions-b4e876b95b

Task Status
wheel-macos-monterey-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp310-arm64 GitHub Actions
wheel-macos-monterey-cp311-amd64 GitHub Actions
wheel-macos-monterey-cp311-arm64 GitHub Actions
wheel-macos-monterey-cp312-amd64 GitHub Actions
wheel-macos-monterey-cp312-arm64 GitHub Actions
wheel-macos-monterey-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-arm64 GitHub Actions
wheel-macos-monterey-cp38-amd64 GitHub Actions
wheel-macos-monterey-cp38-arm64 GitHub Actions
wheel-macos-monterey-cp39-amd64 GitHub Actions
wheel-macos-monterey-cp39-arm64 GitHub Actions
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-amd64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp38-amd64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented Sep 2, 2024

I've addressed your review comments @kou (I didn't know bash had arrays!). I'll merge if CI passes. Thank you!

@pitrou pitrou merged commit 7d4cf37 into apache:main Sep 2, 2024
@pitrou pitrou removed the awaiting merge Awaiting merge label Sep 2, 2024
@pitrou pitrou deleted the gh43883-gcs-testbench-py-version branch September 2, 2024 16:55
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7d4cf37.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…testbench (apache#43884)

We can now use the GCS testbench even if we are testing a Python version that does not support it.

* GitHub Issue: apache#43883

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants