-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Provider Interface Support SPI & Optimize ProviderManager SPI
#4218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider Interface Support SPI & Optimize ProviderManager SPI
#4218
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Provider Interface Support SPI & Optimize ProviderManager SPI
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/DefaultProviderManager.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/foundation/spi/ProviderManager.java
Show resolved
Hide resolved
|
I have read the CLA Document and I hereby sign the CLA |
….spi.ProviderManager.getOrder`
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/DefaultProviderManager.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/DefaultProviderManager.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/NullProviderManager.java
Outdated
Show resolved
Hide resolved
|
updated |
Codecov Report
@@ Coverage Diff @@
## master #4218 +/- ##
=========================================
Coverage 52.58% 52.58%
- Complexity 2631 2632 +1
=========================================
Files 485 486 +1
Lines 15225 15226 +1
Branches 1573 1573
=========================================
+ Hits 8006 8007 +1
- Misses 6663 6664 +1
+ Partials 556 555 -1
Continue to review full report at Codecov.
|
nobodyiam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
ApplicationProviderNetworkProviderinDefaultProviderManagerOrderedinProviderManagerand useServiceBootstrap.loadPrimaryinstead ofcom.ctrip.framework.foundation.internals.ServiceBootstrap#loadFirst. BecausegetManagermethod in classFoundationusecom.ctrip.framework.foundation.internals.ServiceBootstrap#loadFirstto load interfaceProviderManagerimplementation, if I want to define my ownProviderManager, which class has higher priority can not spefic.Brief changelo
Provider Interface Support SPI & Optimize ProviderManager SPI
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.