Skip to content

optimize import/export config #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nobodyiam merged 1 commit into from
Feb 18, 2022
Merged

optimize import/export config #4231

nobodyiam merged 1 commit into from
Feb 18, 2022

Conversation

@lepdou
Copy link
Contributor

@lepdou lepdou commented Feb 17, 2022 •
edited
Loading

What's the purpose of this PR

  1. remove global attribute currentUser, which may cause concurrent bug
  2. import app's source owner name instead of operator

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@lepdou lepdou force-pushed the dev/lepdou/fix_import_export branch from e6644c8 to 27acb60 Compare February 17, 2022 12:31
nobodyiam
nobodyiam approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 0f06662 into apolloconfig:master Feb 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lepdou @nobodyiam