Fix finding URL not respecting --scm-base-url
#196
Merged
+79
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
commented
Aug 18, 2024
| domain = a.ScmClient.GetProviderBaseURL() | ||
| ) | ||
| if domain != scm_domain.DefaultGitHubDomain && domain != scm_domain.DefaultGitLabDomain { | ||
| purl, _ = models.NewPurl(fmt.Sprintf("pkg:%s/%s?repository_url=%s", repo.GetProviderName(), repo.GetRepoIdentifier(), domain)) |
Contributor
Author
There was a problem hiding this comment.
I think it's fine that repository_url is the domain without schema. Some purl examples include schema, others don't.
https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst
| @@ -1,10 +1,13 @@ | |||
| package scm | |||
| package scm_domain | |||
Contributor
Author
There was a problem hiding this comment.
One possible solution to prevent cyclical references.
SUSTAPLE117
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #190.
Tested against an instance of GHES. It works for rules like "CI Runner Debug Enabled" and "Pull Request Runs on Self-Hosted GitHub Actions Runner" but not "GitHub Action from Unverified Creator used". That requires somehow passing the base domain to
PurlFromGithubActionsandPurlFromDockerImage, which could be more complicated.