Migrating code #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 25
Lines ? 182
Branches ? 0
======================================
Hits ? 0
Misses ? 182
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Closed
leogdion
added a commit
that referenced
this pull request
Nov 6, 2025
Implements first 8 fixes from PR #132 code review (Priority 0 items #4-6). ## Type System Migration (Int64 → Int) - Update RestoreImageRecord.fileSize: Int64 → Int - Update XcodeVersionRecord.fileSize: Int64? → Int? - Remove unnecessary Int(record.fileSize) conversions in RecordBuilder - Update IPSWFetcher, AppleDBFetcher, IPSWVersion to use Int - Rename FieldValueExtensions.int64Value → intValue (+ 2 usage updates) ## Boolean Helper Usage - Replace manual `.int64(bool ? 1 : 0)` with `.boolean(bool)` in RecordBuilder (4 locations) - Move FieldValue.boolean() to extension for SwiftLint type_contents_order compliance ## Critical Bug Fixes - Fix force unwrap crash risk in XcodeReleasesFetcher.toDate (use nil-coalescing) - Fix duplicate BushelCloudKitService initialization in SyncEngine (reuse single instance) - Remove silent error swallowing (try? → direct assignment) ## Build Status ✅ Clean build (3.81s) with no errors Related to: #132 (items #1, #4, #5, #6, #10) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.