composefs: prefer std library functions #2050
Conversation
Signed-off-by: Giuseppe Scrivano <[email protected]>
|
we use "ro" in composefs as well: https://github.com/containers/composefs/blob/main/libcomposefs/lcfs-mount.c#L582-L585, but MS_RDONLY should be enough |
avoid dealing directly with file descriptors but use the standard library functions. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
composefs-reduce-unix-pkg-usage
branch
from
232a788 to
39098fb
Compare
|
opened a PR for composefs as well: composefs/composefs#309 @cgwalters PTAL |
| // do not worry about checking the magic number, if the file is invalid | ||
| // we will fail to mount it anyway | ||
| flags := make([]byte, 4) | ||
| nread, err := unix.Pread(fd, flags, 8) |
There was a problem hiding this comment.
I don't really care too much, but I would note that I think we could use https://pkg.go.dev/os#File.ReadAt here instead
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
LGTM (I didn’t look into the MS_RDONLY vs "ro" difference, if any).
|
/lgtm |
4 participants
a couple of cleanups for the composefs backend