Skip to content

Conversation

@fmigneault
Copy link
Collaborator

  • fix detection of executionUnit href using mapping representation
  • patch pytest markers with parametrized
  • allow CLI override of url parameter on each operation

@fmigneault fmigneault self-assigned this Nov 21, 2024
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. process/builtin Issue related to builtin application processes process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Nov 21, 2024
@codecov
Copy link

codecov bot commented Nov 21, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2656 4 2652 19
View the top 3 failed tests by shortest run time
tests.functional.test_cli.TestWeaverClient::test_update_job
Stack Traces | 0.551s run time
Traceback (most recent call last):
  File ".../tests/functional/test_cli.py", line 806, in test_update_job
    assert result.success
AssertionError: assert False
 +  where False = OperationResult(success=False, code=404, message="undefined")\n{\n  "title": "NoSuchJob",\n  "type": "http://www.opengis....": "Could not find job with specified reference.",\n  "status": 404,\n  "cause": "62deaddf-dd2c-4161-b2fe-040fed9ef77b"\n}.success
tests.functional.test_cli.TestWeaverClient::test_execute_manual_monitor_status_and_download_results
Stack Traces | 1.55s run time
Traceback (most recent call last):
  File ".../tests/functional/test_cli.py", line 569, in test_execute_manual_monitor_status_and_download_results
    assert result.success, result.text
AssertionError: {
    "job": "80b08c9d-61c4-4967-ace6-dc7c57e09a3d"
  }
assert False
 +  where False = OperationResult(success=False, code=None, message="Could not find job with specified reference.")\n{\n  "job": "80b08c9d-61c4-4967-ace6-dc7c57e09a3d"\n}.success
tests.processes.test_wps_package::test_stdout_stderr_logging_for_commandline_tool_success
Stack Traces | 3.13s run time
Traceback (most recent call last):
  File ".../tests/processes/test_wps_package.py", line 204, in test_stdout_stderr_logging_for_commandline_tool_success
    assert re.match(
AssertionError: Information expected in:
  
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   1% running    Preparing package logs done.
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   2% running    Launching package...
  WARNING  weaver.config:config.py:69 Setting 'weaver.configuration' not specified, using 'DEFAULT'
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   2% running    Visible application CWL euid:egid [1001:127]
  INFO     cwltool:load_tool.py:111 Resolved '.../tmp/tmp5f73hz4v/mock-process' to 'file://.../tmp/tmp5f73hz4v/mock-process'
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   5% running    Loading package content done.
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   6% running    Retrieve package inputs done.
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   8% running    Convert package inputs done.
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   9% running    Checking package prerequisites... (operation could take a while depending on requirements)
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   9% running    Package ready for execution.
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987  10% running    Running package...
  INFO     cwltool:job.py:268 [job mock-process_3] /tmp/cwltool_out_kvjwo8bz$ docker \
      run \
      -i \
      --mount=type=bind,source=/tmp/cwltool_out_kvjwo8bz,target=/qinAIk \
      --mount=type=bind,source=/tmp/cwltool_tmp_4arrwv5t,target=/tmp \
      --workdir=/qinAIk \
      --read-only=true \
      --log-driver=none \
      --user=1001:127 \
      --rm \
      --cidfile=.../tmp/cwltool_tmp_v0l1clsj/20241121231907-537336.cid \
      --env=TMPDIR=/tmp \
      --env=HOME=/qinAIk \
      alpine:latest \
      echo \
      'Dummy message' > .../tmp/cwltool_out_kvjwo8bz/stdout.log 2> .../tmp/cwltool_out_kvjwo8bz/stderr.log
  INFO     cwltool:job.py:420 [job mock-process_3] completed success
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987  95% running    Package execution done.
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987  98% running    Generate package outputs done.
  INFO     weaver.processes.wps_package|mock-process:wps_package.py:1987 100% succeeded  Package operations complete.
  
  ----- Captured Log (stdout) -----
  Dummy message
  ----- End of Logs -----
  
assert None
 +  where None = <function match at 0x7f69f11fd3f0>(".*cwltool:job.* \\[job mock-process\\].*echo \\\\\\n\\s+'Dummy message' \\> [\\w\\-/\\.]+/stdout\\.log 2\\> [\\w\\-/\\.]+/stderr\\.log\\n.*", '\nINFO     weaver.processes.wps_package|mock-process:wps_package.py:1987   1% running    Preparing package logs done....succeeded  Package operations complete.\n\n----- Captured Log (stdout) -----\nDummy message\n----- End of Logs -----\n', (re.MULTILINE | re.DOTALL))
 +    where <function match at 0x7f69f11fd3f0> = re.match
 +    and   re.MULTILINE = re.MULTILINE
 +    and   re.DOTALL = re.DOTALL

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@fmigneault fmigneault merged commit 9b5dd84 into master Nov 22, 2024
47 of 48 checks passed
@fmigneault fmigneault deleted the fix-url-resolutions branch November 22, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. process/builtin Issue related to builtin application processes process/wps3 Issue related to WPS 3.x (REST-JSON) processes support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants