feat(expect): add asymmetric matchers (#3964) #4366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@iuioiua is this going the right direction? Are you missing something? |
Contributor
|
I'll leave this one to @kt3k, who's lead |
kt3k
reviewed
Feb 22, 2024
expect/_anything_test.ts
Outdated
| import { expect } from "./expect.ts"; | ||
| import { AssertionError, assertThrows } from "../assert/mod.ts"; | ||
|
|
||
| Deno.test("expect().anything()", () => { |
Member
There was a problem hiding this comment.
nit:
Suggested change
| Deno.test("expect().anything()", () => { | |
| Deno.test("expect.anything()", () => { |
Member
|
@javihernant This looks heading in the right direction to me! |
javihernant
changed the title
kt3k
changed the title
kt3k
reviewed
Feb 28, 2024
| Deno.test("expect.anything() as a parameter of toHaveBeenCalled()", () => { | ||
| const mockFn = fn(); | ||
| mockFn(3); | ||
| expect(mockFn).toHaveBeenCalledWith(expect.anything()); |
kt3k
approved these changes
Feb 28, 2024
Member
kt3k
left a comment
kt3k
left a comment
There was a problem hiding this comment.
Looks nicely implemented and tested! Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.