Skip to content

Conversation

@canaleal
Copy link
Member

@canaleal canaleal commented Nov 6, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to issues in #1977

Link to prove your SVG is correct and up-to-date.

Created Line SVGs from the Plain SVGs.

@canaleal canaleal requested a review from Snailedlt November 6, 2023 22:14
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 7, 2023
@lunatic-fox lunatic-fox changed the title updated icon: gimp (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) update icon: gimp (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Nov 9, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little adjustments done! 🔧
The title of this pull request was changed because the pattern for build icons:

r"(?<=^new icon: )\w+ (?=\(.+\))|(?<=^update icon: )\w+ (?=\(.+\))"

Thank you for this contribution and for the quick action to update each icon with a major issue in the next release! 🥇

I'll give priority to review these pull requests today. 🎗️
image
image
image
image

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt merged commit 992021a into devicons:develop Nov 11, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…, line, line-wordmark) (devicons#1979)

* Updated icon Gimp

* Convert stroke to path in `original` and `original-wordmark` versions

---------

Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants