Skip to content

Conversation

@boterop
Copy link
Contributor

@boterop boterop commented Oct 5, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2124

Link to prove your SVG is correct and up-to-date.

https://github.com/reflex-dev

@boterop boterop changed the title new icon: <i>reflex</i> (<i>original, plain</i>) new icon: reflex (original, plain) Oct 5, 2024
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 👍

I added the wordmark versions of the icon and optimized them using SVGOMG.

@canaleal canaleal requested review from a team, ConX, Snailedlt, lunatic-fox and weh and removed request for a team October 14, 2024 03:55
@boterop boterop changed the title new icon: reflex (original, plain) new icon: reflex (original, original-wordmark, plain, plain-wordmark) Oct 17, 2024
@canaleal
Copy link
Member

No odd artifacts in the SVGs. All is good, ready to merge.

image

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 7962db1 into devicons:develop Nov 11, 2024
5 checks passed
@boterop boterop deleted the reflex branch November 12, 2024 15:30
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: reflex (original, original-wordmark, plain, plain-wordmark)
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Jun 24, 2025
@canaleal canaleal mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants