Skip to content

Conversation

@Jorenar
Copy link
Contributor

@Jorenar Jorenar commented Mar 27, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format update icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here

Closes #2394

Link to prove your SVG is correct and up-to-date.

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is perfect, just 1 small change needed with the plain icon.

@Jorenar Jorenar requested a review from canaleal March 30, 2025 03:26
@Jorenar Jorenar requested a review from canaleal March 30, 2025 06:34
@Jorenar Jorenar requested a review from canaleal March 31, 2025 19:06
@Jorenar Jorenar requested a review from canaleal April 6, 2025 00:04
@Jorenar Jorenar changed the title update icon: c (original, plain, line) update icon: c (original, line) Apr 6, 2025
@canaleal
Copy link
Member

canaleal commented Jun 1, 2025

@Jorenar Apologies but can you update this branch? Everything is good to merge.

@Jorenar
Copy link
Contributor Author

Jorenar commented Jun 1, 2025

Apologies but can you update this branch? Everything is good to merge.

@canaleal Certainly!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 32c405d into devicons:develop Jun 1, 2025
5 checks passed
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Jun 24, 2025
@canaleal canaleal mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants