fix displaying svg code in devicon.dev #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a comment above
Thomas-Boi
approved these changes
Jan 4, 2021
Member
Thomas-Boi
left a comment
Thomas-Boi
left a comment
There was a problem hiding this comment.
Hey amacado,
This PR looks good. I'm glad that you were able to catch it and fix it. I'll approve this PR
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
…-bash-plain fix displaying svg code in devicon.dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #444 (comment).
While fixing this bug in #444 I noticed some svg do not fulfill our viewbox requirement (128x128) and therefore the extracted code is wrong. I will create a extra issue for this bug.