Skip to content

Conversation

@informeai
Copy link
Contributor

made due correction of deno svg and update of devicon.json 👍🏼

dependabot bot and others added 22 commits May 11, 2021 02:39
…/hosted-git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>
…/lodash-4.17.21

Bump lodash from 4.17.20 to 4.17.21
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Jul 4, 2021
@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 4, 2021
@Panquesito7 Panquesito7 changed the title new icon: denojs(original,original-wordmark,plain,plain-wordmark) new icon: denojs (original, original-wordmark) Jul 4, 2021
@devicons devicons deleted a comment from github-actions bot Jul 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Couldn't find an icon matching the name in the PR title.

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thomas-Boi, any reasons why the Peek Bot workflow is failing? For me, all looks good. 🤔

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 4, 2021
@Thomas-Boi
Copy link
Member

Hey @informeai and @Panquesito7,

Good news: the peek bot is working now; I have no ideal why it failed before. On the other hand, the SVGs don't look great as icons (see above). Can you please fix it so the white parts are transparent instead of white?

@Panquesito7 Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 4, 2021
@Panquesito7
Copy link
Member

Let's see if that fixes it...😅

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@devicons devicons deleted a comment from github-actions bot Jul 4, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @informeai. Thank you for your contribution! 👍 🎉

@Panquesito7 Panquesito7 requested a review from Thomas-Boi July 4, 2021 23:21
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great now! Thanks for your work 😃

@Panquesito7 Panquesito7 merged commit b13b02d into devicons:develop Jul 4, 2021
@informeai
Copy link
Contributor Author

Happy to contribute ☺️, thanks @Thomas-Boi and @Panquesito7 🙏🏻👍🏻

@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

* Resolves issue devicons#260

* Make the `original` icon version pure SVG

Taken from [Wikipedia](https://es.wikipedia.org/wiki/Archivo:Deno.svg).

* Make the `original-wordmark` icon pure SVG

* Apply suggestions from code review

Co-authored-by: David Leal <[email protected]>

* svg concert for denojs
resolves devicons#709

* update devicon.json and resolves devicons#260

* update devicon.json and resolve devicons#260

* delete files repeats

* Delete denojs-plain-wordmark.svg

* Delete denojs-plain.svg

* Update denojs-original-wordmark.svg

* Update denojs-original.svg

* Update denojs-original.svg

* Update denojs-original-wordmark.svg

* Update devicon.json

* Update denojs-original.svg

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <[email protected]>
Co-authored-by: Wellington Gadelha <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants