-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: denojs (original, original-wordmark) #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]>
…/hosted-git-info-2.8.9 Bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <[email protected]>
…/lodash-4.17.21 Bump lodash from 4.17.20 to 4.17.21
Release v2.12.0
Taken from [Wikipedia](https://es.wikipedia.org/wiki/Archivo:Deno.svg).
Co-authored-by: David Leal <[email protected]>
resolves devicons#709
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem. Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
Panquesito7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thomas-Boi, any reasons why the Peek Bot workflow is failing? For me, all looks good. 🤔
|
Hey @informeai and @Panquesito7, Good news: the peek bot is working now; I have no ideal why it failed before. On the other hand, the SVGs don't look great as icons (see above). Can you please fix it so the white parts are transparent instead of white? |
|
Let's see if that fixes it...😅 |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Panquesito7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @informeai. Thank you for your contribution! 👍 🎉
Thomas-Boi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great now! Thanks for your work 😃
|
Happy to contribute |
* Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]> * Bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <[email protected]> * Resolves issue devicons#260 * Make the `original` icon version pure SVG Taken from [Wikipedia](https://es.wikipedia.org/wiki/Archivo:Deno.svg). * Make the `original-wordmark` icon pure SVG * Apply suggestions from code review Co-authored-by: David Leal <[email protected]> * svg concert for denojs resolves devicons#709 * update devicon.json and resolves devicons#260 * update devicon.json and resolve devicons#260 * delete files repeats * Delete denojs-plain-wordmark.svg * Delete denojs-plain.svg * Update denojs-original-wordmark.svg * Update denojs-original.svg * Update denojs-original.svg * Update denojs-original-wordmark.svg * Update devicon.json * Update denojs-original.svg * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Bui <[email protected]> Co-authored-by: Wellington Gadelha <[email protected]> Co-authored-by: Clemens Bastian <[email protected]> Co-authored-by: David Leal <[email protected]>



made due correction of deno svg and update of devicon.json 👍🏼