Noscript Fix #761
Merged
Noscript Fix #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Boi
reviewed
Jul 21, 2021
Member
|
@theblobscp can you please provide a preview (screenshot) of how this looks when JavaScript is disabled? |
Contributor
Author
|
I did it, but I need to make the font smaller |
Contributor
Author
|
Sorry for the wait, it's fixed now |
Contributor
Author
|
Website with no javascript
|
Panquesito7
approved these changes
Jul 21, 2021
Member
|
Thank you for your contribution. 🙂 |
Thomas-Boi
approved these changes
Jul 21, 2021
Member
Thomas-Boi
left a comment
Thomas-Boi
left a comment
There was a problem hiding this comment.
I think this looks good now. Thank you for improving it 👍
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* Made tag red and header * Added icon to noscript * Removed class from svg * Removed extra sentence * Moved line down * removed icon Co-authored-by: Thomas Bui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a noscript element before, but I wanted to improve it a bit so here it is. The pr is #751 if you want to know